Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyarrow hook #4517

Merged
merged 4 commits into from Nov 26, 2019
Merged

Add pyarrow hook #4517

merged 4 commits into from Nov 26, 2019

Conversation

@caramelomartins
Copy link
Contributor

caramelomartins commented Nov 4, 2019

Note: This is a corrected version of #4500. I did something horrible on my fork and ended up rewriting the history and erasing my commits.

Hey,

I saw #3720 and decided to pull the code into an appropriate hook and submit a PR for it. I have removed pyarrow.formatting and pyarrow.compat.* from the hidden imports as PyInstaller was alerting that those modules could not be found after installing pyarrow.

Thanks,
Hugo

@htgoebel htgoebel mentioned this pull request Nov 12, 2019
@htgoebel htgoebel added the area:hooks label Nov 12, 2019
caramelomartins and others added 2 commits Nov 4, 2019
@htgoebel htgoebel force-pushed the caramelomartins:3720 branch from 27f2bad to 42157ec Nov 12, 2019
[skip ci]
@htgoebel htgoebel merged commit a1190c1 into pyinstaller:develop Nov 26, 2019
1 check was pending
1 check was pending
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@htgoebel

This comment has been minimized.

Copy link
Member

htgoebel commented Nov 26, 2019

Thank you for this pull-request. Well done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.