Repository navigation
rthook utils: add missing argtypes annotations for ctypes-bound functions - #7894
Merged
Merged
Conversation
…ions Add missing argument type annotations for ctypes-bound functions used in _pyi_rth_utils/_win32.py. Most notably, the missing argtypes for `CreateDirectoryW` is causing `OSError: exception: access violation reading 0x00000010` under 32-bit python.
bwoodsend
approved these changes
Aug 28, 2023
The new `_pyi_rth_hook_utils` run-time package must be licensed under permissive license that matches the license of the run-time hooks using it.
bwoodsend
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing argument type annotations for ctypes-bound functions used in _pyi_rth_utils/_win32.py.
Most notably, the missing argtypes for
CreateDirectoryWis causingOSError: exception: access violation reading 0x00000010under 32-bit python.Fixes #7893.