hooks: update PySide6.QtHttpServer hook for PySide6 6.5.3 - #7994
Merged
Merged
Conversation
Explicitly add `PySide6.QtConcurrent` to hidden imports of `QtHttpServer` to fix missing module error in basic import test with PySide6 6.5.3 on Windows. On other OSes, the `QtConcurrent` dependency seems to be automatically inferred due to the `QtHttpServer` extension being linked against the `Qt6Concurrent` shared library. But the explicit hidden import does not hurt in that case, either.
bwoodsend
approved these changes
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly add
PySide6.QtConcurrentto hidden imports ofQtHttpServerto fix missing module error in basic import test with PySide6 6.5.3 on Windows.On other OSes, the
QtConcurrentdependency seems to be automatically inferred due to theQtHttpServerextension being linked against theQt6Concurrentshared library. But the explicit hidden import does not hurt in that case, either.