Repository navigation
If argcomplete is available, use it for CLI completions - #8008
Merged
Merged
Conversation
Member
|
I remember last time I tried to integrate |
bwoodsend
reviewed
Oct 15, 2023
bwoodsend
approved these changes
Oct 16, 2023
rokm
approved these changes
Oct 16, 2023
Member
|
Thanks @singingwolfboy! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
argcompleteadds tab completion for Python CLIs build with theargparsemodule. This pull request sets up the PyInstaller CLIs to useargcompleteif it's installed, but if it's not installed, users can still use the PyInstaller CLIs without tab completion. In addition, this PR adds an "extra" requirement named "completion", so if users runpip install pyinstaller[completion], then Pip will install PyInstaller andargcomplete.I've also added a new CI runner to run the tests with this extra installed, just to verify that the code still behaves as expected -- but since this is such a small change, I didn't think it was worth doubling the number of runners (one with
argcompleteand one without, for every combination ofpython-versionandos), so this CI runner only runs on Ubuntu with the latest version of Python.