Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.path munging is not deduplicated #296

Closed
bitprophet opened this issue Dec 21, 2015 · 0 comments
Closed

sys.path munging is not deduplicated #296

bitprophet opened this issue Dec 21, 2015 · 0 comments
Labels
Bug

Comments

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Dec 21, 2015

Noticed when debugging a silly test runner corner case that my sys.path had approximately 1 zillion copies of some of my test dirs; tracked it down to Loader naively adding to sys.path without testing beforehand.

Granted, this probably only comes up in our own test suite, but you never know what users might stumble on this for other, legit use cases.

@bitprophet bitprophet added the Bug label Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.