Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command execution timeout control #539

Closed
bitprophet opened this issue Jun 19, 2018 · 1 comment
Closed

Command execution timeout control #539

bitprophet opened this issue Jun 19, 2018 · 1 comment
Labels
Milestone

Comments

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 19, 2018

Fabric 1 had a feature which (IIRC) used a threading Timer to raise an exception (which I think then just turned into ye olde crappy abort()) when a command execution took longer than the user desired.

This should live at the Invoke layer for v2, even if Fabric's Runner subclass needs hooks to implement it (though I suspect it may not, as long as we interrupt the remote process correctly when we time out - something that may or may not be necessary locally, I'm not positive.)

@bitprophet
Copy link
Member Author

@bitprophet bitprophet commented Aug 6, 2019

See #645 and commentary. This is about to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.