New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Result so it can consider different "ok" exit values #541

bitprophet opened this Issue Jun 19, 2018 · 0 comments


None yet
1 participant

bitprophet commented Jun 19, 2018

Right now, the runners.Result class defines whether a Runner execution succeeded or failed, in its .ok property-method. At the moment it's a hardcoded == 0; it should become configurable as in Fabric 1, so users can set up for expected nonzero exits without having to try/except.

Should involve:

  • configuration value in the run tree
  • kwarg in run
  • passed into Result during result creation
  • honored by Result.ok

@bitprophet bitprophet added this to the 1.1 milestone Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment