New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal state incorrectly reset to character-buffered at close of session #559

Closed
bitprophet opened this Issue Jul 31, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@bitprophet
Member

bitprophet commented Jul 31, 2018

This is just a rebranding of fabric/fabric#1812 since it turned out to be entirely Invoke's fault. See fabric/fabric#1812 (comment) for a brief summary of the actual problem (and the top of ticket for initial reproduction case - note that it only happens in bash for reasons yet unexplained...)

Currently working on some tests to try and prove the bug, then code to fix ought to be relatively simple (already have it specced out).

bitprophet added a commit that referenced this issue Jul 31, 2018

Initial test and impl proving/fixing #559
Pre-existing character-buffering tests are now broken
because they do not mock realistically enough; fix inbound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment