Fix/positional args with underscore #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Positional arguments with underscores are flagged as positional by storing the name *with* the underscore in a list. However, the flag is set somewhere else in the code, where the underscore has been replaced for a dash. Hence, the positional test fails and the task argument is left in a weird limbo of not being neither positional nor optional. The fix is easy: simply move the positional and optional tests to before the name change happens :)
|
Thanks! Good catch. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #122
Positional arguments with underscores are flagged as positional by storing the name with the underscore in a list. However, the flag is set somewhere else in the code, where the underscore has been replaced for a dash. Hence, the positional test fails and the task argument is left in a weird limbo of not being neither positional nor optional. Also, the argument was getting the default value for positional arguments (None).