Check for a file descriptor before trying to close it #142

Merged
merged 2 commits into from Jun 13, 2014

Projects

None yet

2 participants

@singingwolfboy
Contributor

This was causing a traceback for me:

% inv --list
Traceback (most recent call last):
  File "/usr/local/bin/inv", line 9, in <module>
    load_entry_point('invoke==0.8.1', 'console_scripts', 'inv')()
  File "/usr/local/lib/python2.7/site-packages/invoke/cli.py", line 279, in main
    dispatch(sys.argv)
  File "/usr/local/lib/python2.7/site-packages/invoke/cli.py", line 265, in dispatch
    args, collection, parser_contexts = parse(argv, version=version)
  File "/usr/local/lib/python2.7/site-packages/invoke/cli.py", line 188, in parse
    collection = loader.load(start) if start else loader.load()
  File "/usr/local/lib/python2.7/site-packages/invoke/loader.py", line 52, in load
    fd.close()
AttributeError: 'NoneType' object has no attribute 'close'
@bitprophet
Member

Thanks, this looks legit! Took me a bit to figure it out before I noticed your test, heh.

@bitprophet bitprophet merged commit de42ec0 into pyinvoke:master Jun 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bitprophet bitprophet added a commit that referenced this pull request Jun 13, 2014
@bitprophet bitprophet Changelog re #142, fixes #142 6143efe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment