Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix autoprint #175

Merged
merged 2 commits into from Sep 10, 2014
Merged

Bugfix autoprint #175

merged 2 commits into from Sep 10, 2014

Conversation

@matleh
Copy link

@matleh matleh commented Aug 28, 2014

Fixes autoprint for tasks that are within a Collection.

The main problem is, that Tasks and Calls are mixed but treated all as tasks. Tests for equality work (because of the attribute delegation done by Call) as long as task and call have the same name.

The current fix is probably more of a workaround until the Task and Call handling has settled a bit.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Sep 3, 2014

Ah yea, I can see why the original implementation falls down on subcollections. Good catch!

Re: Task vs Call, we might need to move the normalization of them higher up sometime (ideally they would already be Call objects once they get to the Executor) but that's not something to worry about for now.

@bitprophet bitprophet added this to the 0.10 milestone Sep 3, 2014
@bitprophet bitprophet merged commit 8b7cf7a into pyinvoke:master Sep 10, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.