Bugfix autoprint #175

Merged
merged 2 commits into from Sep 10, 2014

Projects

None yet

2 participants

@matleh
matleh commented Aug 28, 2014

Fixes autoprint for tasks that are within a Collection.

The main problem is, that Tasks and Calls are mixed but treated all as tasks. Tests for equality work (because of the attribute delegation done by Call) as long as task and call have the same name.

The current fix is probably more of a workaround until the Task and Call handling has settled a bit.

Matthias Leh... added some commits Aug 28, 2014
@bitprophet
Member

Ah yea, I can see why the original implementation falls down on subcollections. Good catch!

Re: Task vs Call, we might need to move the normalization of them higher up sometime (ideally they would already be Call objects once they get to the Executor) but that's not something to worry about for now.

@bitprophet bitprophet added this to the 0.10 milestone Sep 3, 2014
@bitprophet bitprophet merged commit 8b7cf7a into pyinvoke:master Sep 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bitprophet bitprophet added a commit that referenced this pull request Sep 10, 2014
@bitprophet bitprophet Changelog re #175 7862b9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment