Pass in project directory when tasks module contains explicit namespace. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `tasks.py` module contains an explict Collection (named either `ns` or `namespace`), the parent directory (used to find the project-specific configuration file (e.g. `invoke.yaml`) is not passed in to the Collection created from the factory method `Collection.from_module`. This caused the file to not be found except when explicitly specified with the -f flag. Compare to the similar Collection() invocation about 12 lines below this change. Fix pyinvoke#234.
|
I'm happy to add a test for this, but I'm not sure the best place to, since it relies on having both tasks.py and invoke.yaml in the same directory. Trying to solve this is what led me down the path to #240, but I don't think there's a good unit test for this problem. An integration test, perhaps? |
|
Naw, there was actually a regular semi-unit test (the ones in the CLI module are in a gray area between unit and integration) that can be copied to work perfectly for this, just needed a new fixture & a tweak to select it; see 3356f62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
tasks.pymodule contains an explict Collection (named eithernsor
namespace), the parent directory (used to find the project-specificconfiguration file (e.g.
invoke.yaml) is not passed in to theCollection created from the factory method
Collection.from_module.This caused the file to not be found except when explicitly specified
with the -f flag. Compare to the similar Collection() invocation about
12 lines below this change.
Fix #234.