Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #265

Merged
merged 1 commit into from Jan 13, 2016
Merged

Build improvements #265

merged 1 commit into from Jan 13, 2016

Conversation

@thedrow
Copy link
Contributor

@thedrow thedrow commented Jul 27, 2015

Added PyPy3 to the build, moved to container based infrastructure and enabled pip caching.

@thedrow
Copy link
Contributor Author

@thedrow thedrow commented Jul 27, 2015

Can you explain why the build fails so I can fix it?
Is it because PyPy3 is an implementation of Python 3.2?

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jul 30, 2015

Thanks for this! The issue must be that our (travis.yml) test to skip doc-builds on 3.2 (Sphinx doesn't support it) isn't correctly triggering on PyPy3, I bet TRAVIS_PYTHON_VERSION isn't being set to "3.2" in that case (guessing "PYPY" is in there somewhere, or...something?)

Compare https://travis-ci.org/pyinvoke/invoke/jobs/72795107#L5996 to https://travis-ci.org/pyinvoke/invoke/jobs/72795111#L1027 - "real" Python 3.2 correctly skips the docs build step, but PyPy3 does not.

I don't see the build output stating what that value is, you'll want to make some test commits adding things like - echo TRAVIS_PYTHON_VERSION: '$TRAVIS_PYTHON_VERSION' or whatnot, so we can see what the value is.

Loading

@bitprophet bitprophet added this to the 0.11 milestone Jul 30, 2015
@bitprophet bitprophet merged commit 7602291 into pyinvoke:master Jan 13, 2016
1 of 2 checks passed
Loading
bitprophet added a commit that referenced this issue Jan 13, 2016
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 13, 2016

FTR we nixed 3.2 recently so that should be moot now. I merged and we'll see if Travis likes the sum total of the changes soon...

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 13, 2016

OK, as semi-expected, PyPy3 fails because of Sphinx wanting Python 3.2+, but passes everything else: https://travis-ci.org/pyinvoke/invoke/jobs/102019458

Loading

@thedrow thedrow deleted the patch-1 branch Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants