Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port prefix/cd context managers for run/sudo #446

Merged
merged 3 commits into from Jun 2, 2017

Conversation

@rpkilby
Copy link
Contributor

@rpkilby rpkilby commented May 23, 2017

No description provided.

@bitprophet bitprophet added the Feature label May 24, 2017
@bitprophet bitprophet added this to the 1.0 milestone May 24, 2017
@rpkilby rpkilby changed the title Add context manager for prefixing calls to run/sudo Port prefix/cd context managers for run/sudo May 24, 2017
For example, one of the most common uses of this tool is with the
``workon`` command from `virtualenvwrapper
<http://www.doughellmann.com/projects/virtualenvwrapper/>`_::

This comment has been minimized.

@bitprophet

bitprophet May 24, 2017
Member

This is now https://virtualenvwrapper.readthedocs.io so we should probs update it!

if path.startswith('~') or path.startswith('/'):
break

paths = [path.replace(' ', '\ ') for path in self.command_cwds[i:]]

This comment has been minimized.

@bitprophet

bitprophet May 24, 2017
Member

Forget offhand but we may want to see if there's a stronger "escape this path" function somewhere we can reuse - think escaping tildes or slashes in filenames and dumb shit like that.

@rpkilby
Copy link
Contributor Author

@rpkilby rpkilby commented May 25, 2017

All passing on CI now.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented May 31, 2017

a) your avatar is hilarious in a Github context, b) haven't forgotten about this! Still doing post-PyCon triage but I have this open in a "deal with it soon" browser tab... 😒

@rpkilby
Copy link
Contributor Author

@rpkilby rpkilby commented May 31, 2017

No worries. I'm aware of the very many plates you have 😄

@bitprophet bitprophet merged commit c8101f7 into pyinvoke:master Jun 2, 2017
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 93.37%)
Details
codecov/project 93.47% (+0.09%) compared to 161625f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Jun 2, 2017
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 2, 2017

Also, realized there were two other open tickets about this, that I can now close. Woo! Thanks yet again.

bitprophet added a commit that referenced this pull request Jun 5, 2017
As-is, was causing issues in Fabric 2. This should help.

Also now documenting the (tweaked) config value that was implicitly used
in #446's addition of Context._runner.
@rpkilby rpkilby deleted the rpkilby:ctx-prefix branch Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.