Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #407 Windows shell compatibility error #494

Closed
wants to merge 3 commits into from
Closed

Fixes #407 Windows shell compatibility error #494

wants to merge 3 commits into from

Conversation

@garrettXCIV
Copy link

@garrettXCIV garrettXCIV commented Nov 28, 2017

Fixes #407, based on @mkusz solution in #371, by changing Config.global_defaults <invoke.config.Config.global_defaults>. This is done first, by checking if the OS is Windows, and if so, second, changing the value of defaults['run']['shell'] to the Windows default shell setting, the value of the environment variable COMSPEC.

@mkusz

This comment has been minimized.

Copy link
Contributor

@mkusz mkusz commented on tests/config.py in ff646f0 Nov 28, 2017

I think that for windows should be cmd.exe only since by default it's in $PATH. Correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants