Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accept Path objects #607

merged 5 commits into from Dec 31, 2020


Copy link

@florisla florisla commented Jan 6, 2019

This is a rebase (with minor modifications) of #583.

The original 583 stalled on AppVeyor, but that is disabled now so this should pass CI.

Closes #583 - original PR
Closes #681 - more recent but similar PR
Fixes #454 - original issue
Fixes #577 - duplicate issue
Fixes #658 - duplicate issue

Copy link

Any news on this PR? Run into #577 today.

@florisla florisla force-pushed the 454-context-cd-with-path-object branch from ae95728 to 83cc422 Compare January 20, 2020 09:01
Copy link
Contributor Author

Rebased on master.

Copy link

russkel commented Mar 2, 2020

Would be really nice to get this merged. @bitprophet ?

bitprophet added a commit that referenced this pull request Dec 31, 2020
Test didn't need to use Path objects; only needs to test
the contract being defined.
@bitprophet bitprophet merged commit 54b28be into pyinvoke:master Dec 31, 2020
Copy link

Out in 1.5!

Copy link
Contributor Author

florisla commented Dec 31, 2020 via email

Copy link

russkel commented Jan 1, 2021

Hi @florisla. Thanks, I worked this out soon after I posted it and deleted the comment. Thanks regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
5 participants