Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Context.cd and .prefix behaviour on exception #640

Closed
wants to merge 1 commit into from

Conversation

@cytadela8
Copy link
Contributor

@cytadela8 cytadela8 commented May 13, 2019

When exception happens inside with statement it's escalated to the
contextmanager from with statement. By placing `self.command_cwds.pop()'
in finally block we make sure command prefixes are handled correctly on
exceptions in user code.

When exception happens inside with statement it's escalated to the
contextmanager from with statement. By placing `self.command_cwds.pop()'
in finally block we make sure command prefixes are handled correctly on
exceptions in user code.
@omarmarquez
Copy link

@omarmarquez omarmarquez commented May 31, 2019

+1

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 3, 2019

Thanks for this, #557 beat you to the with cd fix but missed the sibling change to with prefix 👍

@omarmarquez
Copy link

@omarmarquez omarmarquez commented Jun 25, 2019

Great that this have been fixed. When can expect it to be merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants