The ``Loader`` should seek towards the file system to find a collection #87

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mhahn
mhahn commented Sep 21, 2013

This allows "invoke" to be called within sub directories of a project.

@bitprophet
Member

Note to self: #92 probably duplicates this.

Michael Hahn The ``Loader`` should seek towards the file system to find a collection
This allows "invoke" to be called within sub directories of a project.
1cf92fa
@bitprophet
Member

#131 also semi related to this (though not exactly.)

In addition, I just pushed 625cb8e and e3ba34b which fix a commonish problem re: third party tasks.py modules masking "local" ones.

However, that's also only somewhat related - I'm not sure I understood what this ticket meant before but now I do, the scenario described is:

  1. Have a folder with a tasks.py
  2. Don't install it into Python's sys.path in any way
  3. Enter a subdirectory
  4. Try inv -l and watch it fail to find anything.

The reason I didn't really "get" this before is my typical scenario is to "skip" step 2 above - all my tasks.py are in Python projects installed to Python's path via pip install -e or python setup.py develop. When this is done, that tasks.py is now discoverable via sys.path and is then loaded by Invoke no matter where your CWD happens to be.

I'll try to actually review this PR (and compare it to #92) soon.

@bitprophet bitprophet added a commit that closed this pull request May 3, 2014
@bitprophet bitprophet Changelog, closes #92, closes #87 f75f3d3
@bitprophet bitprophet closed this in f75f3d3 May 3, 2014
@bitprophet
Member

This should work as of the next feature release (or master :)). For more discussion see the latest comments on #92. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment