-
Notifications
You must be signed in to change notification settings - Fork 8
Fix PLC0415 #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PLC0415 #428
Conversation
WalkthroughThe Ruff linter configuration in Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
80-87: Avoid project-wide suppression of PLC0415; prefer targeted# noqa: PLC0415or import refactors.Disabling
PLC0415for the entire codebase masks mid-function/module-level imports that could:• Hurt import determinism and readability
• Introduce hidden side-effects that complicate static analysis and caching
• Degrade cold-start performance (deferred imports belong inif TYPE_CHECKINGor lazy-loading helpers)If only a handful of files require non-top-level imports (e.g., to break circular dependencies), add inline
# noqa: PLC0415comments or restrict the ignore rule via per-module overrides instead of the globalignorelist.[tool.ruff.lint] ... ignore = [ ... - # ignore imports which are not at the top of a module - "PLC0415", + # PLC0415 disabled locally where unavoidable ]This keeps the linter helpful elsewhere while still unblocking the problematic spots.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: unittest_matrix (ubuntu-latest, 3.13)
- GitHub Check: unittest_matrix (ubuntu-latest, 3.9)
- GitHub Check: unittest_matrix (ubuntu-latest, 3.11)
- GitHub Check: unittest_matrix (macos-latest, 3.13)
- GitHub Check: unittest_matrix (ubuntu-latest, 3.10)
- GitHub Check: unittest_matrix (ubuntu-latest, 3.12)
- GitHub Check: unittest_matrix (windows-latest, 3.13)
- GitHub Check: unittest_old
- GitHub Check: pip_check
- GitHub Check: minimal
- GitHub Check: notebooks
- GitHub Check: coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 17 17
Lines 966 966
=======================================
Hits 785 785
Misses 181 181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit