Building a working pyjamas desktop on Mac OS X using webkit gtk+ #19

Open
pyjsorg opened this Issue Apr 27, 2012 · 3 comments

Comments

Projects
None yet
1 participant
Contributor

pyjsorg commented Apr 27, 2012

I am posting here because I haven't figured out how to post a git patch to the wiki. There are a number of Darwin specific issues that are somewhat the fault of Apple, WebKit, etc. Anyhow, I have based my work from the python_codegen branch with revision 103cf3b45b16462a70de35d082d3100b7ee87e59.

Please excuse the commented out lines in WebKitTools/GNUmakefile.am as I didn't take the time to repair the issues arising from the fact that this WebKit code still tries to use QuickDraw which has been deprecated by Apple and either doesn't fully exist in Mac OS 10.6.8 or has been sufficiently changed to make it a pain to try to compile some of the WebKitTools.

Please check http://pyjs.org/wiki/pyjamasmaxosxwebkitgtk/ for more information

Original issue: http://code.google.com/p/pyjamas/issues/detail?id=704 (March 17, 2012 04:22:39)

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on April 03, 2012 23:04:32:
jeff this is superb!

if you can do "#if OS(DARWIN)" around the bits that are otherwise commented out
in the GNUMakefile.am i can put this straight in.

yeah really don't worry about the WebKitTools stuff (GtkLauncher) but we can't
completely comment those out: making them conditionally compile is the correct
way.

l.

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on April 03, 2012 23:09:29:
ok, right, what i've done is i've added and pushed everything but the GNUmakefile.am
changes: if you can pull those and add if OS_DARWIN that would be amazing.

you did an "if OS_DARWIN" once already so you know that trick will work.
only do a git format-patch for just that part, not the rest, obviously,
because i've already committed and pushed it.

good stuff jeff!

+++ b/WebCore/GNUmakefile.am
@@ -3474,7 +3474,12 @@ endif
if WITH_GTK

webcore_sources += \

  •   WebCore/editing/gtk/SelectionControllerGtk.cpp
    
  •   WebCore/editing/gtk/SelectionControllerGtk.cpp 
    
    +if OS_DARWIN
Contributor

pyjsorg commented Apr 27, 2012

From Jeff.Van...@gmail.com on April 04, 2012 14:43:03:
I've done this (if !OS_DARWIN). I am currently testing the build process to make sure my edits work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment