New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS packer compatibility patch #358

Open
pyjsorg opened this Issue Apr 27, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@pyjsorg
Contributor

pyjsorg commented Apr 27, 2012

Hello,

I've made a small patch against current trunk (r2389) to fix some
compatibility issues with Dean Edwards' JS packer. Before the patch,
packing JS files as generated by pyjsbuild (I tested by packing all files
in lib/ when compiling with -m) resulted in non working JS output.

The problems were all in pyjslib.py and of two kinds:

  • missing semicolons
  • "for (;;)" which the packer translated into "for (;)" (thinking it was
    safe to remove a double semicolon)

Hope this comes in time for 0.7 :-)

Original issue: http://code.google.com/p/pyjamas/issues/detail?id=361 (January 21, 2010 23:05:22)

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on January 26, 2010 18:03:47:
taa.

please can you provide a copyright notice, modification to CREDITS and copyright
files, thanks.

l.

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on January 26, 2010 18:03:47:
taa.

please can you provide a copyright notice, modification to CREDITS and copyright
files, thanks.

l.

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From a.mottola@gmail.com on January 26, 2010 20:02:06:
Heh, didn't think such small changes deserved me a place in the copyright...
Anyway, I've attached a modified patch built against current r2391.

Angelo

Contributor

pyjsorg commented Apr 27, 2012

From a.mottola@gmail.com on January 26, 2010 20:02:06:
Heh, didn't think such small changes deserved me a place in the copyright...
Anyway, I've attached a modified patch built against current r2391.

Angelo

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on June 25, 2010 18:08:03:
ok added sorry i missed this, could you double-check it's all happy?

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on June 25, 2010 18:08:03:
ok added sorry i missed this, could you double-check it's all happy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment