New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloading in SplitPanel shadows definitions in Superclasses when it should not #368

Open
pyjsorg opened this Issue Apr 27, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@pyjsorg
Contributor

pyjsorg commented Apr 27, 2012

To reproduce:
Try to use getOffsetHeight() or similar with a SplitPanel instance.
Expected:
Return height of SplitPanel main element (via UIObject.getOffsetHeight)
Observed:
Exception in SplitPanel.getOffsetHeight because that requires passing element.

Probably want to check whether elem is defined or somesuch.
Thanks for doing Pyjamas!

Original issue: http://code.google.com/p/pyjamas/issues/detail?id=351 (January 02, 2010 23:54:54)

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on January 20, 2010 12:27:43:
SplitPanel is not intended for "generic" use it is a private method for use by
derived classes VerticalSplitPanel and HorizontalSplitPanel.

hmmm... none of those methods should be there, they should all be "non-class" methods.

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on January 20, 2010 12:27:43:
SplitPanel is not intended for "generic" use it is a private method for use by
derived classes VerticalSplitPanel and HorizontalSplitPanel.

hmmm... none of those methods should be there, they should all be "non-class" methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment