New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmaps v3 interface #402

Open
pyjsorg opened this Issue Apr 27, 2012 · 7 comments

Comments

Projects
None yet
1 participant
@pyjsorg
Contributor

pyjsorg commented Apr 27, 2012

Hi,

Please see attached the wrappers for google maps v3 that Daniel and I have developed.

I included also a test for some gmaps functions - gmapv3, that should go on
\examples\gmaps

Original issue: http://code.google.com/p/pyjamas/issues/detail?id=317 (November 01, 2009 18:59:12)

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on November 03, 2009 12:35:53:
brilliant!

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on November 03, 2009 12:35:53:
brilliant!

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on November 03, 2009 12:45:56:
ok.

  • files need to be in unix fileformat not dos (sorry. personal preference)
  • you're using tabs rather than spaces, and some of the indents are 3-spaces
    e.g. class Greed in GMapV3
  • you're mixing tabs and spaces sometimes in the same code-block. please use
    4 spaces, always.
  • it would be helpful if you could also include the JSONRPC service which
    does getPoints. or - specifically - the modifications made (as a diff)
    to getPoints.
  • it's also infinitely preferable to receive submissions in patch format
    rather than bundled-up-in-a-zip-file.

if you install git-win32 that will get you all of the development tools that you need

  • git, tar, diff, patch etc.

i can fix all of the above - it's just a pain to do so :)

let me know if you want me to commit these straight away and then you can do an svn
or git-svn patch to correct them, or if you'd like to re-submit.

ta,

l.

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on November 03, 2009 12:45:56:
ok.

  • files need to be in unix fileformat not dos (sorry. personal preference)
  • you're using tabs rather than spaces, and some of the indents are 3-spaces
    e.g. class Greed in GMapV3
  • you're mixing tabs and spaces sometimes in the same code-block. please use
    4 spaces, always.
  • it would be helpful if you could also include the JSONRPC service which
    does getPoints. or - specifically - the modifications made (as a diff)
    to getPoints.
  • it's also infinitely preferable to receive submissions in patch format
    rather than bundled-up-in-a-zip-file.

if you install git-win32 that will get you all of the development tools that you need

  • git, tar, diff, patch etc.

i can fix all of the above - it's just a pain to do so :)

let me know if you want me to commit these straight away and then you can do an svn
or git-svn patch to correct them, or if you'd like to re-submit.

ta,

l.

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From Carlos.C...@gmail.com on November 03, 2009 15:13:21:
Luke,

We will re-submit in a few days, with the errors fixed and a few more tests.

Thank you for the tip - I will install git-win32

~carlos

Contributor

pyjsorg commented Apr 27, 2012

From Carlos.C...@gmail.com on November 03, 2009 15:13:21:
Luke,

We will re-submit in a few days, with the errors fixed and a few more tests.

Thank you for the tip - I will install git-win32

~carlos

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From idn...@gmail.com on November 04, 2009 11:29:44:
here is the source code in a zip file to be unpacked at PYJAMASROOT/library

And, as a separate zip file, the src code for the examples, that should be unpacked
in PYJAMASROOT

(next upgrades will be send as patch files!)

note1: the examples also include html files in a sub-folder "public". This is because
for now, they have to load the javascript gmaps api in the html. I think we could do
that dynamically from python... we will work on that

daniel

Contributor

pyjsorg commented Apr 27, 2012

From idn...@gmail.com on November 04, 2009 11:29:44:
here is the source code in a zip file to be unpacked at PYJAMASROOT/library

And, as a separate zip file, the src code for the examples, that should be unpacked
in PYJAMASROOT

(next upgrades will be send as patch files!)

note1: the examples also include html files in a sub-folder "public". This is because
for now, they have to load the javascript gmaps api in the html. I think we could do
that dynamically from python... we will work on that

daniel

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on November 09, 2009 11:52:53:
carlos, daniel, can you send me sourceforge usernames, i'll add you to the list, you
can sort this out.

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on November 09, 2009 11:52:53:
carlos, daniel, can you send me sourceforge usernames, i'll add you to the list, you
can sort this out.

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From Carlos.C...@gmail.com on November 09, 2009 13:22:38:
my user on sourceforge is softsalsa

Contributor

pyjsorg commented Apr 27, 2012

From Carlos.C...@gmail.com on November 09, 2009 13:22:38:
my user on sourceforge is softsalsa

@pyjsorg

This comment has been minimized.

Show comment
Hide comment
@pyjsorg

pyjsorg Apr 27, 2012

Contributor

From luke.lei...@gmail.com on November 09, 2009 18:44:24:
ok you're added.

Contributor

pyjsorg commented Apr 27, 2012

From luke.lei...@gmail.com on November 09, 2009 18:44:24:
ok you're added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment