Skip to content

fixed class 'set' so that if None is an element, it is treated properly. #770

Merged
merged 2 commits into from Aug 2, 2012

3 participants

@earney
earney commented Aug 2, 2012

modified pyjslib.py by adding a hash function for NoneType, added check to hash functions to return null if passed argument obj is null.

modified SyntaxTest27.py, removed self.fail/return statements to show that changes to pyjslib.py works. Added 1 to correct a assertEqual test.

modified pyv8test.py, changed --dynamic to --dynamic-load to get rid of a depreated warning about --dynamic

@keesbos keesbos was assigned Aug 2, 2012
@anthonyrisinger
Polyglot Pythonistas member

this LGTM, but i want @keesbos to just verify the pyjslib bits because it's been a little while since i've rummaged thru there.

@anthonyrisinger
Polyglot Pythonistas member

@earney btw, thanks a bunch for fixing up these sorts of things -- much appreciated.

@keesbos keesbos merged commit 2af5f68 into pyjs:master Aug 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.