Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixed class 'set' so that if None is an element, it is treated properly. #770

Merged
merged 2 commits into from Aug 2, 2012

Conversation

Projects
None yet
3 participants
Contributor

earney commented Aug 2, 2012

modified pyjslib.py by adding a hash function for NoneType, added check to hash functions to return null if passed argument obj is null.

modified SyntaxTest27.py, removed self.fail/return statements to show that changes to pyjslib.py works. Added 1 to correct a assertEqual test.

modified pyv8test.py, changed --dynamic to --dynamic-load to get rid of a depreated warning about --dynamic

earney added some commits Aug 2, 2012

@ghost ghost assigned keesbos Aug 2, 2012

Member

anthonyrisinger commented Aug 2, 2012

this LGTM, but i want @keesbos to just verify the pyjslib bits because it's been a little while since i've rummaged thru there.

Member

anthonyrisinger commented Aug 2, 2012

@earney btw, thanks a bunch for fixing up these sorts of things -- much appreciated.

keesbos added a commit that referenced this pull request Aug 2, 2012

Merge pull request #770 from earney/setlibtest
fixed class 'set' so that if None is an element, it is treated properly.

@keesbos keesbos merged commit 2af5f68 into pyjs:master Aug 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment