From aea47d14ad90f7c5a607d96886f08c0f1ee2605a Mon Sep 17 00:00:00 2001 From: Pierre Sassoulas Date: Sun, 17 Sep 2023 16:03:48 +0200 Subject: [PATCH] [unbalanced-tuple-unpacking] Add a regression tests for #7710 --- doc/whatsnew/fragments/7710.bugfix | 4 ++++ .../functional/u/unbalanced_tuple_unpacking.py | 7 +++++++ .../u/unbalanced_tuple_unpacking.txt | 18 +++++++++--------- 3 files changed, 20 insertions(+), 9 deletions(-) create mode 100644 doc/whatsnew/fragments/7710.bugfix diff --git a/doc/whatsnew/fragments/7710.bugfix b/doc/whatsnew/fragments/7710.bugfix new file mode 100644 index 0000000000..61ee5243d7 --- /dev/null +++ b/doc/whatsnew/fragments/7710.bugfix @@ -0,0 +1,4 @@ +``sys.argv`` is now always correctly considered as impossible to infer (instead of +using the actual values given to pylint). + +Closes #7710 diff --git a/tests/functional/u/unbalanced_tuple_unpacking.py b/tests/functional/u/unbalanced_tuple_unpacking.py index 21e497be87..caca148cdf 100644 --- a/tests/functional/u/unbalanced_tuple_unpacking.py +++ b/tests/functional/u/unbalanced_tuple_unpacking.py @@ -1,5 +1,7 @@ """Check possible unbalanced tuple unpacking """ from __future__ import absolute_import + +import sys from typing import NamedTuple from functional.u.unpacking.unpacking import unpack @@ -160,3 +162,8 @@ def my_function(mystring): # https://github.com/pylint-dev/pylint/issues/5998 x, y, z = (1, 2) # [unbalanced-tuple-unpacking] + +# https://github.com/pylint-dev/pylint/issues/7710 +# Using a lot of args, so we have a high probability to still trigger the problem if +# we add arguments to our unittest command later +(p, q, r, s, t, u, v, w, x, y, z) = sys.argv diff --git a/tests/functional/u/unbalanced_tuple_unpacking.txt b/tests/functional/u/unbalanced_tuple_unpacking.txt index 651e098403..848b3dfbaf 100644 --- a/tests/functional/u/unbalanced_tuple_unpacking.txt +++ b/tests/functional/u/unbalanced_tuple_unpacking.txt @@ -1,9 +1,9 @@ -unbalanced-tuple-unpacking:11:4:11:27:do_stuff:"Possible unbalanced tuple unpacking with sequence '(1, 2, 3)': left side has 2 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:17:4:17:29:do_stuff1:"Possible unbalanced tuple unpacking with sequence '[1, 2, 3]': left side has 2 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:23:4:23:29:do_stuff2:"Possible unbalanced tuple unpacking with sequence '(1, 2, 3)': left side has 2 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:82:4:82:28:do_stuff9:"Possible unbalanced tuple unpacking with sequence defined at line 7 of functional.u.unpacking.unpacking: left side has 2 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:96:8:96:33:UnbalancedUnpacking.test:"Possible unbalanced tuple unpacking with sequence defined at line 7 of functional.u.unpacking.unpacking: left side has 2 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:140:8:140:43:MyClass.sum_unpack_3_into_4:"Possible unbalanced tuple unpacking with sequence defined at line 128: left side has 4 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:145:8:145:28:MyClass.sum_unpack_3_into_2:"Possible unbalanced tuple unpacking with sequence defined at line 128: left side has 2 labels, right side has 3 values":INFERENCE -unbalanced-tuple-unpacking:157:0:157:24::"Possible unbalanced tuple unpacking with sequence defined at line 151: left side has 2 labels, right side has 0 values":INFERENCE -unbalanced-tuple-unpacking:162:0:162:16::"Possible unbalanced tuple unpacking with sequence '(1, 2)': left side has 3 labels, right side has 2 values":INFERENCE +unbalanced-tuple-unpacking:13:4:13:27:do_stuff:"Possible unbalanced tuple unpacking with sequence '(1, 2, 3)': left side has 2 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:19:4:19:29:do_stuff1:"Possible unbalanced tuple unpacking with sequence '[1, 2, 3]': left side has 2 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:25:4:25:29:do_stuff2:"Possible unbalanced tuple unpacking with sequence '(1, 2, 3)': left side has 2 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:84:4:84:28:do_stuff9:"Possible unbalanced tuple unpacking with sequence defined at line 7 of functional.u.unpacking.unpacking: left side has 2 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:98:8:98:33:UnbalancedUnpacking.test:"Possible unbalanced tuple unpacking with sequence defined at line 7 of functional.u.unpacking.unpacking: left side has 2 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:142:8:142:43:MyClass.sum_unpack_3_into_4:"Possible unbalanced tuple unpacking with sequence defined at line 130: left side has 4 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:147:8:147:28:MyClass.sum_unpack_3_into_2:"Possible unbalanced tuple unpacking with sequence defined at line 130: left side has 2 labels, right side has 3 values":INFERENCE +unbalanced-tuple-unpacking:159:0:159:24::"Possible unbalanced tuple unpacking with sequence defined at line 153: left side has 2 labels, right side has 0 values":INFERENCE +unbalanced-tuple-unpacking:164:0:164:16::"Possible unbalanced tuple unpacking with sequence '(1, 2)': left side has 3 labels, right side has 2 values":INFERENCE