-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change lines
to lists
#5009
Change lines
to lists
#5009
Conversation
Pull Request Test Coverage Report for Build 1235194292
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there's a reason for this change, that I don't know of :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Btw. list[str]
requires 3.9
or from __future__ import annotations
. List[str]
would have worked.
@Pierre-Sassoulas See the discussion here: #4973 (comment) |
Yeah I was too quick and then I thought "wait this is implicit"! |
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
/CC @cdce8p
This changes some occurrences of
lines
to become lists