Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for too-many-function-args #7395

Merged
merged 1 commit into from
Sep 2, 2022
Merged

False positive for too-many-function-args #7395

merged 1 commit into from
Sep 2, 2022

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

False positive too-many-function-args

Closes #6592

@mbyrnepr2
Fix false positive for too-many-function-args when a function cal…
04a3501 
…l is assigned to a class attribute inside the class where the function is defined.

Closes pylint-dev#6592
@coveralls
Copy link

coveralls commented Sep 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2972963452

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 95.319%
Totals Coverage Status
Change from base Build 2966731658: 0.0005%
Covered Lines: 16941
Relevant Lines: 17773
💛 - Coveralls

@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review September 1, 2022 16:10
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are no longer emitted:

  1. too-many-function-args:
    Too many positional arguments for method call
    https://github.com/django/django/blob/838cc0f449f96c157cb44eb91984a2753edc7f42/django/db/utils.py#L237
  2. too-many-function-args:
    Too many positional arguments for method call
    https://github.com/django/django/blob/838cc0f449f96c157cb44eb91984a2753edc7f42/django/db/utils.py#L238

This comment was generated for commit 04a3501

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Sep 1, 2022
Pierre-Sassoulas
Pierre-Sassoulas reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have a question about the functional test.

tests/functional/a/arguments.py Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.2 milestone Sep 1, 2022
@DanielNoord DanielNoord changed the title False positive | too-many-function-args False positive for too-many-function-args Sep 1, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 880095c into pylint-dev:main Sep 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.15.2, 2.15.1 Sep 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Sep 2, 2022
@mbyrnepr2 mbyrnepr2 deleted the 6592_too_many_function_args branch September 2, 2022 07:49
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Sep 6, 2022
Pierre-Sassoulas pushed a commit to Pierre-Sassoulas/pylint that referenced this pull request Sep 6, 2022
@mbyrnepr2 @Pierre-Sassoulas
Fix false positive for too-many-function-args when a function cal…
c4a770d 
…l is assigned to a class attribute inside the class where the function is defined. (pylint-dev#7395)

Closes pylint-dev#6592
Pierre-Sassoulas pushed a commit that referenced this pull request Sep 6, 2022
@mbyrnepr2 @Pierre-Sassoulas
Fix false positive for too-many-function-args when a function cal…
7a1fbb9 
…l is assigned to a class attribute inside the class where the function is defined. (#7395)

Closes #6592
webknjaz added a commit to cherrypy/cheroot that referenced this pull request Sep 28, 2022
@webknjaz
Ignore false-positive too-many-function-args
e3a6978 
Refs:
* pylint-dev/pylint#6592
* pylint-dev/pylint#7395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

Incorrect too-many-function-args for a function defined and called within a class
4 participants
@mbyrnepr2 @coveralls @Pierre-Sassoulas @DanielNoord