-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump dill to >= 0.3.6, prevents tests hanging with python3.11 #7918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sandrotosi ! The fix I did is based on https://github.com/PyCQA/pylint/pull/7838/files#r1031123153. Look like dill did not handle metadata correctly and we do need to be precise if we want to support 3.7 to 3.11.
Pull Request Test Coverage Report for Build 3686020157
💛 - Coveralls |
Seems like forcing the CI environment to be cache invalidated made a pre-existing issue appear for pypy 3.8 (brought by #7863 ?). I'll check that later on. |
This comment has been minimized.
This comment has been minimized.
f5f8c4c
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit f5f8c4c |
Merging because the pypy 3.8 problem exists on main anyway. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7918-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a93635a4a220b16b83b859c2c7f4421ce8d05cd
# Push it to GitHub
git push --set-upstream origin backport-7918-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x Then, create a pull request where the |
…7918) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Backported in 83668de |
@Pierre-Sassoulas Do we know why |
No idea, the error (only on pypy 3.8) is very strange and seem related to #7863 (?) |
Should we revert that commit then? |
It's just an intuition based on the test fail message (so : maybe 😄 ). TBH I don't have a lot of respect for pypy as I never used it myself so just excluding the interpreter in conf would not bother me. |
Second time my PR causes failures on just PyPy 3.8 😭 |
The bug is really strange btw: import dataclasses
from dataclasses import dataclass
@dataclass
class CustomDataClass: # multiple-statements ??!
my_var: list[int]
@dataclasses.dataclass
class CustomDataClass2: # multiple-statements ??!
my_var: list[int]
@dataclass()
class CustomDataClass3: # multiple-statements ??!
my_var: list[int] |
@Pierre-Sassoulas |
See #7945 for a hot fix, if we have a real fix then we can apply it instead. |
Fixes #7916