Support globbing pattern for input specification#8312
Conversation
alexey-pelykh
force-pushed
the
feature/input-globbing
branch
from
de7f3ee to
7061f87
Compare
alexey-pelykh
force-pushed
the
feature/input-globbing
branch
from
7061f87 to
357557a
Compare
|
@Pierre-Sassoulas @DudeNr33 do we want to add this to 2.17 as well? The CI misbehaved here as well |
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
I closed/opened to launch the CI again, feel free to do that or to rebase on upstream/main and push force if you need to :)
| With globbing pattern | ||
| --------------------- | ||
|
|
||
| It is also possible to specify both directories and files using globbing patterns:: | ||
|
|
||
| pylint [options] packages/*/src | ||
|
|
There was a problem hiding this comment.
Imo this should be in the On module packages or directories paragraph
There was a problem hiding this comment.
Yet it's also applicable to On files - it can't be in both paragraphs at the same time
There was a problem hiding this comment.
IMO renaming the headline to Globbing support would be good, as it makes it a bit clearer that this section just informs you about the possibility to use glob patterns.
There was a problem hiding this comment.
Globbing permits to handle file/module/package, the distinction could be removed entirely maybe ?
There was a problem hiding this comment.
IMHO, that section of docs should be refactored, yet I don't have enough knowledge to do that confidently
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8312 +/- ##
==========================================
+ Coverage 95.46% 95.56% +0.09%
==========================================
Files 177 178 +1
Lines 18704 18765 +61
==========================================
+ Hits 17856 17932 +76
+ Misses 848 833 -15
|
This comment has been minimized.
This comment has been minimized.
|
To fix the spelling check you can add |
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
This comment has been minimized.
This comment has been minimized.
DudeNr33
left a comment
DudeNr33
left a comment
There was a problem hiding this comment.
Only two minor remarks from my side. Logic looks good to me.
| With globbing pattern | ||
| --------------------- | ||
|
|
||
| It is also possible to specify both directories and files using globbing patterns:: | ||
|
|
||
| pylint [options] packages/*/src | ||
|
|
There was a problem hiding this comment.
IMO renaming the headline to Globbing support would be good, as it makes it a bit clearer that this section just informs you about the possibility to use glob patterns.
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit a8865f4 |
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM, it makes 2.17.0 consistent (all the globbing added) and we can refactor the doc in #7496.
3 participants
Type of Changes
Description
Closes #8310