Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document startup.homepage* prefs #218

Closed
wants to merge 1 commit into from
Closed

document startup.homepage* prefs #218

wants to merge 1 commit into from

Conversation

nodiscc
Copy link
Contributor

@nodiscc nodiscc commented Feb 25, 2017

Add disabled prefs to UI section
May be useful as some users might consider these "automatic connections"
Ref. #153

user.js Outdated
// https://secure.wikimedia.org/wikibooks/en/wiki/Grsecurity/Application-specific_Settings#Firefox_.28or_Iceweasel_in_Debian.29
user_pref("javascript.options.methodjit.chrome", false);
user_pref("javascript.options.methodjit.content", false);

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do with these?

@pyllyukko
Copy link
Owner

Should you add -p these so that you don't revert previous stuff?

Add disabled prefs to UI section
May be useful as some users might consider thses "automatic connections"
Ref. #153
@nodiscc
Copy link
Contributor Author

nodiscc commented Feb 25, 2017

Rebased

@pyllyukko
Copy link
Owner

I still feel that these homepage thingies aren't necessary in the user.js. Might be minor annoyance, but not really any kind of privacy/security issue. Wouldn't you say?

And also to keep it tidier.

@pyllyukko
Copy link
Owner

Maybe we could document these in the wiki?

@nodiscc
Copy link
Contributor Author

nodiscc commented Feb 27, 2017

I still feel that these homepage thingies aren't necessary in the user.js. Might be minor annoyance, but not really any kind of privacy/security issue. Wouldn't you say?

I agree. Let's close this PR.

Maybe we could document these in the wiki?

:/ I think information is currently too much scattered between user.js comments, the wiki, the readme... In my experience it leads to duplicate/outdated/don't-know-where-to-look documentation. It can be made cleaner eg by:

So closing. Let me know if you agree with the above and if I should open a new issue.

@nodiscc nodiscc closed this Feb 27, 2017
@pyllyukko
Copy link
Owner

Moving all info from these wiki pages to the user.js file itself, alongside relevant prefs/sections

Yes, the wiki should be cleaned up, gathering the relevant parts and then closing it completely. All the relevant info should be in the README.

    If the info does not fit in user.js it's probably not relevant, remove it.

I agree.

Move some tests from https://github.com/pyllyukko/user.js#online-tests to relevant prefs/sections in user.js

Moved or copied? I think the online tests section is good in the README as it is, but some of the tests could be also in the user.js.

Move info from https://github.com/pyllyukko/user.js#what-does-it-do to section descriptions in user.js, and instead generate the "What does it do?" section do from section descriptions in user.js (ezpz sed/awk/Makefile magic)

I don't think that's a good idea. I think we should have it the similar way it's now, kinda summarizing different aspects of the hardening.

Move https://github.com/pyllyukko/user.js/wiki/FAQ, to README.md

Haven't looked what's there :P

Closing the wiki: Github Flavored Markdown is not very portable, there are authenticity issues with world-writable wikis, all in all it's harder to maintain than generating it from static comments/.md files. If you think this bloats the user.js file/README, just discard irrelevant information.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants