This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Remove redundant AdvancedBoolean*Subtensor classes #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-boolean-subtensor-grad
branch
from
8e971bf to
ddb271f
Compare
This change also fixes the `set_subtensor` boolean gradient bug in Theano#105.
brandonwillard
force-pushed
the
fix-boolean-subtensor-grad
branch
from
ddb271f to
cac907d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant
AdvancedBoolean*Subtensorclasses and merges all functionality into theAdvanced*Subtensorclasses. In doing so, theset_subtensorboolean gradient bug in #105 is also fixed.