This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Move get_test_value method to the Variable (sub)classes #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
brandonwillard
force-pushed
the
move-get_test_value-to-classes
branch
2 times, most recently
from
fd3f071 to
fa53408
Compare
The test value computation steps were also extracted from `PureOp.__call__` and put into a stand-alone `compute_test_value` function.
brandonwillard
force-pushed
the
move-get_test_value-to-classes
branch
from
fa53408 to
3fb7528
Compare
brandonwillard
force-pushed
the
move-get_test_value-to-classes
branch
from
3fb7528 to
5ef9f83
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
_get_test_valueimplementation fromPureOpto theVariableclasses they actually apply.The test value computation steps are also extracted from
PureOp.__call__and put into a stand-alonecompute_test_valuefunction.