Jump to conversation

Unresolved conversations (3)

michaelosthege

Jun 28, 2023

🤯

tests/distributions/test_distribution.py

michaelosthege

Jun 28, 2023

```suggestion self.register_rv(unobserved_rv, f"{name}_unobserved", transform=transform) ``` this would match the `_observed` for the other and maybe avoid confusion?

Outdated

pymc/model.py

Ricardo Vieira and Michael Osthege

ricardoV94

Jun 27, 2023

This would have failed in the call to `as_tensor_variable` or `shared` anyway

pymc/data.py

Resolved conversations (3)

michaelosthege

Jun 28, 2023

```suggestion @pytest.mark.parametrize("obs_component_selected", [True, False]) def test_multivariate_constant_mask_separable(self, obs_component_selected): mask = pt.constant(np.array([[obs_component_selected] * 4], dtype=bool)) ``` simpler?

Outdated

tests/distributions/test_distribution.py

Ricardo Vieira

michaelosthege

Jun 28, 2023

```suggestion tune=5, draws=7, ```

Outdated

tests/backends/test_arviz.py

michaelosthege

Jun 28, 2023

```suggestion unobserved_rv and mask : Tuple of TensorVariable The unobserved component of the RV and respective indexing mask joined_rv The symbolic join of the observed and unobserved components. ```

Outdated

pymc/distributions/distribution.py