Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set batches to number of samples if smaller than default #1606

Closed
tyarkoni opened this issue Dec 15, 2016 · 1 comment
Closed

set batches to number of samples if smaller than default #1606

tyarkoni opened this issue Dec 15, 2016 · 1 comment

Comments

@tyarkoni
Copy link
Contributor

I ran into this while debugging a model, and it probably won't come up very often, but if the number of samples in a MultiTrace is < 100, and you try to call summary on it, the size of the batches argument isn't adjusted, which causes slicing to fail. Can presumably be fixed by setting batches to the min of batches and length of the trace. I'll submit a PR when I have a chance if no one else gets to it first (just opening this so I don't forget).

@twiecki
Copy link
Member

twiecki commented Dec 16, 2016

Sounds like a valid fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants