New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SFGS, CSG and Elliptical Slice samplers to pymc3-experiments #3353

Open
twiecki opened this Issue Jan 24, 2019 · 11 comments

Comments

Projects
None yet
5 participants
@twiecki
Copy link
Member

twiecki commented Jan 24, 2019

These three samplers are not well supported and do not appear to really be used. They are mostly experimental and should be in the main software. Thus, they should be moved to https://github.com/pymc-devs/pymc3-experimental alongside any tests and docs (tests and docs do not need to compile/function). If someone picks them up and demonstrates their usefulness they can certainly make their way back, but they have lied dormant for too long.

@Akamoha

This comment has been minimized.

Copy link

Akamoha commented Jan 25, 2019

So this would mean removing all the work done in #2544?

@twiecki

This comment has been minimized.

Copy link
Member Author

twiecki commented Jan 25, 2019

@Akamoha Yes, alongside the SFGS.

@eigenfoo

This comment has been minimized.

Copy link
Member

eigenfoo commented Jan 25, 2019

#3233 and #3357 are both problems to do with the CSG sampler. Is the plan to simply remove CSG altogether? If so, then perhaps we should close those issues.

@junpenglao

This comment has been minimized.

Copy link
Member

junpenglao commented Jan 25, 2019

Could we move to a new repo maybe? (pymc-devs/experiment?) Along with Elliptical Slice Sampling.

@twiecki

This comment has been minimized.

Copy link
Member Author

twiecki commented Jan 25, 2019

@junpenglao I like that.

@twiecki

This comment has been minimized.

Copy link
Member Author

twiecki commented Jan 25, 2019

@twiecki twiecki changed the title Remove CSG sampler Move SFGS, CSG and Elliptical Slice samplers to pymc3-experiments Jan 25, 2019

@junpenglao

This comment has been minimized.

Copy link
Member

junpenglao commented Jan 25, 2019

Awesome ;-)

@junpenglao

This comment has been minimized.

Copy link
Member

junpenglao commented Jan 25, 2019

I can finally dump all my codes on Laplace approximation etc there :-|||||

@twiecki

This comment has been minimized.

Copy link
Member Author

twiecki commented Jan 25, 2019

@Akamoha Do you want to take this one on?

@harshitbansal05

This comment has been minimized.

Copy link

harshitbansal05 commented Feb 1, 2019

hey, @twiecki can I work on this one?

@twiecki

This comment has been minimized.

Copy link
Member Author

twiecki commented Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment