Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 support? #3465

Closed
ahartikainen opened this issue May 6, 2019 · 5 comments · Fixed by #3466
Closed

Python 3.5 support? #3465

ahartikainen opened this issue May 6, 2019 · 5 comments · Fixed by #3466

Comments

@ahartikainen
Copy link
Contributor

If you have questions about a specific use case, or you are not sure whether this is a bug or not, please post it to our discourse channel: https://discourse.pymc.io

Description of your problem

Hi, is Python 3.5 supported anymore?

/usr/local/envs/testenv_3.5_PYSTAN_latest_PYRO_latest_EMCEE_2/lib/python3.5/site-packages/_pytest/python.py:511: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/local/envs/testenv_3.5_PYSTAN_latest_PYRO_latest_EMCEE_2/lib/python3.5/site-packages/py/_path/local.py:701: in pyimport
    __import__(modname)
<frozen importlib._bootstrap>:968: in _find_and_load
    ???
<frozen importlib._bootstrap>:957: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:664: in _load_unlocked
    ???
<frozen importlib._bootstrap>:634: in _load_backward_compatible
    ???
/usr/local/envs/testenv_3.5_PYSTAN_latest_PYRO_latest_EMCEE_2/lib/python3.5/site-packages/_pytest/assertion/rewrite.py:299: in load_module
    six.exec_(co, mod.__dict__)
arviz/tests/test_plots.py:8: in <module>
    import pymc3 as pm
/usr/local/envs/testenv_3.5_PYSTAN_latest_PYRO_latest_EMCEE_2/lib/python3.5/site-packages/pymc3/__init__.py:10: in <module>
    from .model_graph import model_to_graphviz
E     File "/usr/local/envs/testenv_3.5_PYSTAN_latest_PYRO_latest_EMCEE_2/lib/python3.5/site-packages/pymc3/model_graph.py", line 50
E       vars: MutableSet[RV] = set(self.var_list)
E           ^
E   SyntaxError: invalid syntax

Please provide any additional information below.
This happened after 9f3bba0

Versions and main components

  • PyMC3 Version: 3.6 git Master
  • Theano Version: 1.0.4
  • Python Version: Python 3.5.6
  • Operating system: ArviZ Docker (conda/miniconda3)
  • How did you install PyMC3: pip
@lucianopaz
Copy link
Contributor

Strange, type hints should be fully supported in 3.5.6. Is this blocking arviz's CI?

@ahartikainen
Copy link
Contributor Author

Yes

https://travis-ci.org/arviz-devs/arviz/builds/528762356

It might be that we have some old package somewhere.

@lucianopaz
Copy link
Contributor

Actually, the error is happening because of a variable annotation, not a type hint. That was introduced in python 3.6. I'll make a quick fix so that Arviz CI can still build properly.

@lucianopaz
Copy link
Contributor

@ahartikainen, thanks for reporting this! Our CI environment only tests on python 3.6, so we hadn't noticed this during testing.

@lucianopaz
Copy link
Contributor

Should be fixed by #3466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants