New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build #1290

Merged
merged 12 commits into from Aug 15, 2016

Conversation

Projects
None yet
3 participants
@ColCarroll
Copy link
Member

ColCarroll commented Aug 15, 2016

Factors out the steps from the travis build so they may be run locally, and reasoned about separately. Getting set up and running tests should now be as easy as:

$ . ./scripts/install_miniconda.sh  # doesn't do anything if `conda` is already in the path
...
$ . ./scripts/create_testenv.sh  # sets up virtual environment
...
$ . ./scripts/test.sh -vv --with-timer -e test_examples  # for example

Travis build works as before. This might also be a first step towards a CONTRIBUTING.md file.

@twiecki

This comment has been minimized.

Copy link
Member

twiecki commented Aug 15, 2016

This is great, thanks!

@twiecki

This comment has been minimized.

Copy link
Member

twiecki commented Aug 15, 2016

How do you mean "This might also be a first step towards a CONTRIBUTING.md file."?

@twiecki twiecki merged commit 5446efe into pymc-devs:master Aug 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ColCarroll

This comment has been minimized.

Copy link
Member

ColCarroll commented Aug 15, 2016

Was looking at contributing, and had trouble setting up a dev environment (mostly the problem was not using conda). A short guide to installing, running tests, and submitting pull requests may help. happy to help with that if it is wanted!

@twiecki

This comment has been minimized.

Copy link
Member

twiecki commented Aug 15, 2016

Definitely, that'd be great.

@fonnesbeck

This comment has been minimized.

Copy link
Member

fonnesbeck commented Aug 17, 2016

Yes, thanks for this. I have added an issue for us to get guidelines for contributing added to the repository #1293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment