Unpin theano #2728
Closed
Unpin theano #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are some meaningful failures in |
|
Strange, test_variational_inference.py pass locally for me (MacOS). |
ColCarroll
force-pushed
the
unpin-theano
branch
from
290f5fa
to
ebdd49b
Compare
|
Same – I have a python 2.7 installation and can recreate the problem from Rebased and pushed again to see if it fixes itself - there was a theano 1.0.1 release a week ago on pypi (none of the changes look like they should help us). |
ColCarroll
force-pushed
the
unpin-theano
branch
from
6e3a088
to
ee276e3
Compare
|
Trying again... #2777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found two problems, which both seem related to CI and testing, not to functionality.
-- if you
conda install mkl-serviceyou need to also setMKL_THREADING_LAYER=GNU(which the error message tells you). We don't requiremkl-service(though we do recommend it), and it only gets installed increate-testenv.sh, so I don't think we need to do anything else with that.-- new theano imports
nosein its unittests, and we have a unittest where we import theano unittests, so I added that to therequirements-dev.txt.