Sample ppc does not shuffle by default #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColCarroll
force-pushed
the
update-ppc
branch
from
049910e
to
5574449
Compare
junpenglao
reviewed
Sep 27, 2018
| @@ -1126,9 +1126,9 @@ def sample_posterior_predictive(trace, samples=None, model=None, vars=None, size | |||
| for slc, idx in enumerate(indices): | |||
| if nchain > 1: | |||
| chain_idx, point_idx = np.divmod(idx, len_trace) | |||
| param = trace._straces[chain_idx].point(point_idx) | |||
| param = trace._straces[chain_idx % nchain].point(point_idx) | |||
There was a problem hiding this comment.
I'll add a PR to numpy for my new divmodmod
|
Just rebased this - let me know if there are any changes that should be made on these PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3208.
This makes default
sample_posterior_predictivebehavior to sample from the trace in order, and not shuffle it. It was a smaller change than expected.