Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard argument order (mu, sigma, tau) in NormalMixture #3405

Merged
merged 4 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@fredcallaway
Copy link
Contributor

fredcallaway commented Mar 12, 2019

I tested it by running notebooks/marginalized_gaussian_mixture_model.ipynb

@fredcallaway

This comment has been minimized.

Copy link
Contributor Author

fredcallaway commented Mar 12, 2019

Adresses #3400

@lucianopaz

This comment has been minimized.

Copy link
Contributor

lucianopaz commented Mar 12, 2019

Hmm. The tests exceeded the maximum time available. We should address this in a separate PR. Once it's fixed, you can rebase this on top.

@twiecki

This comment has been minimized.

Copy link
Member

twiecki commented Mar 12, 2019

Als needs a line in the release notes.

@@ -8,7 +8,7 @@
- `GLM.from_formula` and `LinearComponent.from_formula` can extract variables from the calling scope. Customizable via the new `eval_env` argument. Fixing #3382.

### Maintenance

- Add `sigma`, `tau`, and `sd` to signature of `NormalMixture`.

This comment has been minimized.

@twiecki

twiecki Mar 12, 2019

Member

Can you move that to the bottom instead?

Show resolved Hide resolved pymc3/distributions/mixture.py Outdated

twiecki and others added some commits Mar 12, 2019

Update pymc3/distributions/mixture.py
Co-Authored-By: fredcallaway <fredc@llaway.com>

@lucianopaz lucianopaz merged commit a806b7b into pymc-devs:master Mar 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.5%) to 88.738%
Details
@lucianopaz

This comment has been minimized.

Copy link
Contributor

lucianopaz commented Mar 12, 2019

Thanks a lot, @fredcallaway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.