Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Differential Equation API #3590
This work is a part of Google Summer of Code 2019.
This PR adds:
Sorry, I was having some issues with the last PR so I thought I would just start again.Here is a link to the old PR should you need to reference it.
Check out this pull request on ReviewNB: https://app.reviewnb.com/pymc-devs/pymc3/pull/3590
You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.
ColCarroll left a comment
Left a few nitpicky things, and one musing suggestion. None of them are dealbreakers, and I will be delighted when this gets merged, even if none of the changes get made.
As another musing suggestion, running
python -m pylint --enable=all pymc3/step_methods/hmc/nuts.py
on each file you changed -- many suggestions will be silly, or ones we do not enforce, but some are helpful.
If you want to be really fancy
git diff --name-only HEAD master | xargs python -m pylint --enable=all
will pipe just the changed files through pylint
michaelosthege left a comment
Just some minor comments on some code style. The notebook could also use spaces on the inline comments. I know its picky, but for me its jarring after seeing a bunch of PEP8 style comments.
On the notebook the PyMC3 version is shown, just to double check will that be the version of PyMC3 that includes the ODE solver, or will we increment the PyMC3 version to 3.8 once this ODE solver get merged to master?
@twiecki Not sure how to update the docs, but I did find a reference to the other ODE notebook in
@canyon289 Changes made and made the notebook more pep-8 friendly wrt spaces (I will never get used to one space after assignment, no space after arguments).
If that's all, are we ready to merge?