Helping with slice from life #1702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds normalize_indices_for_mlx to convert NumPy integer and float types, MLX scalar arrays, and slice components to Python int/float for MLX compatibility. Updates all MLX Subtensor and IncSubtensor dispatch functions to use this normalization, resolving errors with np.int64 indices and slices. Expands tests to cover various np.int64 and NumPy scalar indexing scenarios, including original failing cases.
Normalize indices and slice components to Python int in MLX subtensor dispatch to address strict MLX requirements. Update tests to cover np.int64 indices and slices, ensuring compatibility and resolving previous failures with advanced and incremental subtensor operations.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change