-
Notifications
You must be signed in to change notification settings - Fork 87
Add reporting layer #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reporting layer #554
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 96.40% 96.50% +0.09%
==========================================
Files 29 31 +2
Lines 2724 4173 +1449
==========================================
+ Hits 2626 4027 +1401
- Misses 98 146 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@drbenvincent I can help fixing the conflicts of this one with main :) |
|
View / edit / reply to this conversation on ReviewNB juanitorduz commented on 2025-11-12T11:44:05Z Why did you change the color theme? |
juanitorduz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix the change in theme for the plots (at the moment it's mixed in the notebooks)? Besides that LGTM
Might be related to #538 |
|
ah ok! so do you wanna leave it like this and fix it later? |
juanitorduz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we create an issue that harmonizes the theme on the notebooks then?
|
No. Think it was done kind of accident in Cursor. I noticed some other minor plot quirks. I'll try to run all the notebooks in VS Code. |
|
seems the plots are better :) |
Extended the _compute_rope_probability function to support a 'decrease' direction, returning the probability that the effect is less than -min_effect. Added corresponding unit test. Updated documentation to clarify ROPE calculation for all directions and expanded reporting statistics and usage examples.
📚 Documentation preview 📚: https://causalpy--554.org.readthedocs.build/en/554/