Skip to content

Conversation

@drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent commented Nov 11, 2025


📚 Documentation preview 📚: https://causalpy--554.org.readthedocs.build/en/554/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbenvincent drbenvincent added the enhancement New feature or request label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 96.68966% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.50%. Comparing base (42bfcda) to head (ebee053).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
causalpy/reporting.py 91.27% 46 Missing ⚠️
causalpy/experiments/base.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   96.40%   96.50%   +0.09%     
==========================================
  Files          29       31       +2     
  Lines        2724     4173    +1449     
==========================================
+ Hits         2626     4027    +1401     
- Misses         98      146      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drbenvincent drbenvincent marked this pull request as ready for review November 12, 2025 11:19
@drbenvincent drbenvincent added documentation Improvements or additions to documentation major labels Nov 12, 2025
@juanitorduz
Copy link
Collaborator

@drbenvincent I can help fixing the conflicts of this one with main :)

@review-notebook-app
Copy link

review-notebook-app bot commented Nov 12, 2025

View / edit / reply to this conversation on ReviewNB

juanitorduz commented on 2025-11-12T11:44:05Z
----------------------------------------------------------------

Why did you change the color theme?


Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the change in theme for the plots (at the moment it's mixed in the notebooks)? Besides that LGTM

@drbenvincent
Copy link
Collaborator Author

Can we fix the change in theme for the plots (at the moment it's mixed in the notebooks)? Besides that LGTM

Might be related to #538

@juanitorduz
Copy link
Collaborator

ah ok! so do you wanna leave it like this and fix it later?

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we create an issue that harmonizes the theme on the notebooks then?

@drbenvincent
Copy link
Collaborator Author

No. Think it was done kind of accident in Cursor. I noticed some other minor plot quirks. I'll try to run all the notebooks in VS Code.

@juanitorduz
Copy link
Collaborator

seems the plots are better :)

Extended the _compute_rope_probability function to support a 'decrease' direction, returning the probability that the effect is less than -min_effect. Added corresponding unit test. Updated documentation to clarify ROPE calculation for all directions and expanded reporting statistics and usage examples.
@drbenvincent drbenvincent added this to the 0.6.0 milestone Nov 12, 2025
@drbenvincent drbenvincent merged commit 7dea992 into main Nov 12, 2025
10 checks passed
@drbenvincent drbenvincent deleted the reporting branch November 12, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use proper wording for scikit-learn Add built-in "probability-of-effect" and lift summaries for ITS (and other designs)

3 participants