Skip to content

Authenticate websocket connections#10914

Merged
p0psicles merged 3 commits into
developfrom
feature/fix-ws-sec-vul
Sep 5, 2022
Merged

Authenticate websocket connections#10914
p0psicles merged 3 commits into
developfrom
feature/fix-ws-sec-vul

Conversation

@p0psicles
Copy link
Copy Markdown
Contributor

@p0psicles p0psicles commented Sep 5, 2022

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@stealthcopter

Copy link
Copy Markdown

@stealthcopter stealthcopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that unauthenticated connections are no longer permitted 👍

@p0psicles p0psicles merged commit 782361e into develop Sep 5, 2022
@p0psicles p0psicles deleted the feature/fix-ws-sec-vul branch September 5, 2022 19:45
PaulLiang1 pushed a commit to PaulLiang1/Medusa that referenced this pull request Oct 10, 2022
* Authenticate websocket connections

* fix flake issues.

* flake2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants