fix nzbget test #1899
Merged
fix nzbget test #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0psicles
reviewed
Jan 4, 2017
| if use_https == 'false': | ||
| use_https = False | ||
| else: | ||
| use_https = True |
There was a problem hiding this comment.
use_https = bool(use_https) didn't work?
p0psicles
reviewed
Jan 4, 2017
| if use_https == 'false': | ||
| use_https = False | ||
| else: | ||
| use_https = True | ||
| connected_status = nzbget.testNZB(host, username, password, use_https) |
There was a problem hiding this comment.
The current values are 'on' 'off', they're now 'true' 'false'. Python sees all 4 values as truthy values and sets it as true. 😞
There was a problem hiding this comment.
There was a problem hiding this comment.
So you could do:
connected_status = nzbget.testNZB(host, username, password, config.checkbox_to_value(use_https))
checkbox_to_value works on: 'on', 'off', 'true', 'false'. It doesn't work on True, False
OmgImAlexis
force-pushed
the
fix-nzbget
branch
from
f9746b2
to
2acb4e8
Compare
p0psicles
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes nzbget using https at all times in the test.
We need the True/False section as current values are stored as on/off so next time the user runs this it'll fix it all up.