Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unicode_literals to GenericProvider #677

Merged
merged 5 commits into from
Jun 9, 2016
Merged

Added unicode_literals to GenericProvider #677

merged 5 commits into from
Jun 9, 2016

Conversation

p0psicles
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide
  • Also adapted all providers, to make use of the future import unicode_literals
  • Removed the decode()/encode()
  • Cleaned up some double to single quotes
  • Added proper exceptions for the provider results items
  • Some logging cleanup using format()

@p0psicles
Added unicode_literals to GenericProvider
4933292 
* Also adapted all providers, to make use of the future import unicode_literals
* Removed the decode()/encode()
* Cleaned up some double to single quotes
* Added proper exceptions for the provider results items
* Some logging cleanup using format()
@p0psicles p0psicles added Concluded Needs review Needs testing Requires testing to make sure it's working as intended labels Jun 9, 2016
p0psicles
p0psicles reviewed Jun 9, 2016
View reviewed changes
sickbeard/providers/newznab.py
@@ -125,7 +125,6 @@ def get_providers_list(data):
providers_dict[default.name].enable_daily = default.enable_daily
providers_dict[default.name].enable_backlog = default.enable_backlog
providers_dict[default.name].enable_manualsearch = default.enable_manualsearch
providers_dict[default.name].catIDs = default.catIDs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the cause for an issue where the category id's are always overwritten, after a restart. You could change the categories in the provider_config. But a restart would revert it back to 5030,5040

@p0psicles p0psicles mentioned this pull request Jun 9, 2016
Closed
3 tasks
@medariox
Copy link
Contributor

medariox commented Jun 9, 2016 •
edited by duramato
Loading

Approved

Approved with PullApprove

1 similar comment
@p0psicles
Copy link
Contributor Author

p0psicles commented Jun 9, 2016 •
edited by duramato
Loading

Approved

Approved with PullApprove

@p0psicles p0psicles merged commit e1efe5c into stand-providers Jun 9, 2016
p0psicles pushed a commit that referenced this pull request Jun 18, 2016
@medariox @p0psicles
Standardize providers (#665)
4994e6b 
* Standardize first 10 providers

* Small anizb update

* Small bluetigers update

* Next 10 providers

* Added unicode_literals to GenericProvider (#677)

* Added unicode_literals to GenericProvider

* Also adapted all providers, to make use of the future import unicode_literals
* Removed the decode()/encode()
* Cleaned up some double to single quotes
* Added proper exceptions for the provider results items
* Some logging cleanup using format()

* Now Really remove the .decodes()

* Also removed the encodes.

* Fixed after a search/replace

* Fixed docstrings

* Next 11 providers

* Next 11 providers, removed sceneelite

* Last 9 providers

* Remove sceneelite from init

* Renamed all search_params to search_strings

* Fix for GFTracker

* Fix TNTVillage

* Fix HDTorrents

* Fix Extratorrent

* Fix HDSpace

* Use string in SQL with unicode_literals in GenericProvider

* Fix BITHDTV

* Fix TVChaosUK

* Added flag to newznab, for torznab providers. If it's torznab then results are sorted by seeders in search.py.

* Improve BitSnoop

* Improve Anizb

* Improve Bluetigers

* Cleanup BTdigg

* Improve Hounddawgs

* Improve FreshOn

* More improvements and cleanups

* Fix ThePirateBay

* Fix for omgwtfnzb, needed a default value, cause getattr doesn't do that by default.

* Add size to freshon, cleanup, fix for tvchaosuk

* Improve size parsing code Freshon

* Fixes for ExtraTorrent and HDTorrents

* Fixed bithdtv

* For when it's not getting back the 750px tables.

* Fix tokyotoshokan provider errors

* Fixed properSearch.

* listPropers does an sql, but accessing the row, requires it to use b''

* Added newznab search by search_query fallback, when search by tvdbid does not give back results.

* Fix HDTorrents, use urljoin, partial rewrite

* Fix rare Zooqle error

* Improve HDTorrents, bring back ugly hack

* Improve TNTVillage, fix daily search, much more

* Fix BIT-HDTV

* More standardization

* More standardization

* Bring back eng releases only option

* small fixup

* Small tnt change

* Update daily search url

* Remove freeleech option for MTV

* Remove TypeError from connection time out

* FIx repeated keyword in dict

* More standardization

* Standardize method names and order

* FIx missed URL join

* Standardize string formatting

* Last small changes

* Change TPB url, update cache to 20 min

* More providers (#698)

* Remove redundant character escapes

* Use augmented assignment

* Fix indentation

* Use six.iteritems for py3 compatibility

* Store hash for torrentproject
@labrys labrys deleted the prov-unicode-fixes branch June 19, 2016 01:46
p0psicles added a commit that referenced this pull request Jun 19, 2016
@p0psicles
Moved seeders sorting out of providers code and into the sickbeard/se… (
d78a963 
#658)

* Moved seeders sorting out of providers code and into the sickbeard/search.py searchProviders() code.

* Removed the lambda sort from all providers
* Corrected bug introducted in TVCache
* Removed bogus condition from GenericProvider. That condition can never be true.

* Standardize providers (#665)

* Standardize first 10 providers

* Small anizb update

* Small bluetigers update

* Next 10 providers

* Added unicode_literals to GenericProvider (#677)

* Added unicode_literals to GenericProvider

* Also adapted all providers, to make use of the future import unicode_literals
* Removed the decode()/encode()
* Cleaned up some double to single quotes
* Added proper exceptions for the provider results items
* Some logging cleanup using format()

* Now Really remove the .decodes()

* Also removed the encodes.

* Fixed after a search/replace

* Fixed docstrings

* Next 11 providers

* Next 11 providers, removed sceneelite

* Last 9 providers

* Remove sceneelite from init

* Renamed all search_params to search_strings

* Fix for GFTracker

* Fix TNTVillage

* Fix HDTorrents

* Fix Extratorrent

* Fix HDSpace

* Use string in SQL with unicode_literals in GenericProvider

* Fix BITHDTV

* Fix TVChaosUK

* Added flag to newznab, for torznab providers. If it's torznab then results are sorted by seeders in search.py.

* Improve BitSnoop

* Improve Anizb

* Improve Bluetigers

* Cleanup BTdigg

* Improve Hounddawgs

* Improve FreshOn

* More improvements and cleanups

* Fix ThePirateBay

* Fix for omgwtfnzb, needed a default value, cause getattr doesn't do that by default.

* Add size to freshon, cleanup, fix for tvchaosuk

* Improve size parsing code Freshon

* Fixes for ExtraTorrent and HDTorrents

* Fixed bithdtv

* For when it's not getting back the 750px tables.

* Fix tokyotoshokan provider errors

* Fixed properSearch.

* listPropers does an sql, but accessing the row, requires it to use b''

* Added newznab search by search_query fallback, when search by tvdbid does not give back results.

* Fix HDTorrents, use urljoin, partial rewrite

* Fix rare Zooqle error

* Improve HDTorrents, bring back ugly hack

* Improve TNTVillage, fix daily search, much more

* Fix BIT-HDTV

* More standardization

* More standardization

* Bring back eng releases only option

* small fixup

* Small tnt change

* Update daily search url

* Remove freeleech option for MTV

* Remove TypeError from connection time out

* FIx repeated keyword in dict

* More standardization

* Standardize method names and order

* FIx missed URL join

* Standardize string formatting

* Last small changes

* Change TPB url, update cache to 20 min

* More providers (#698)

* Remove redundant character escapes

* Use augmented assignment

* Fix indentation

* Use six.iteritems for py3 compatibility

* Store hash for torrentproject
labrys pushed a commit that referenced this pull request Jun 19, 2016
@p0psicles @labrys
Added unicode_literals to GenericProvider (#677)
073efd6 
* Added unicode_literals to GenericProvider

* Also adapted all providers, to make use of the future import unicode_literals
* Removed the decode()/encode()
* Cleaned up some double to single quotes
* Added proper exceptions for the provider results items
* Some logging cleanup using format()

* Now Really remove the .decodes()

* Also removed the encodes.

* Fixed after a search/replace

* Fixed docstrings
@fernandog fernandog removed the Needs testing Requires testing to make sure it's working as intended label Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Concluded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0psicles @medariox @fernandog