New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cmh and breslow-day tests #9
Conversation
@annepym Why are these tests in a different file? We have a file called stats.py for the various statistical tests. It would be convenient to have all our statistical tests in one place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm wondering generally if an entirely new file is required. regardless, some small things like variables names and documentation should be improved before merging
auditai/cmh.py
Outdated
|
||
pcmh = 1 - stats.chi2.cdf(cmh, 1) | ||
return cmh, pcmh | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an example of these tests in one of our example notebooks? The purpose is to clarify how this test would used in a typical machine learning problem.
Is this going to be merged in soon? It'd be awesome to actually use this in the upcoming client analysis. (I think this is a public repo, so won't say who the AI analysis is for :) ) |
@VishalMurali makes a good point that this should be moved to stats.py |
I've added a notebook that walks through the functions with examples (CMH_test_example.ipynb). I'm going to defend that the utility functions for CMH should have a standalone folder within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this looks good to me
WOOHOO! |
Added a separate file including functions for Cochran-Mantel-Haenszel and Breslow-Day tests, per Kelly's request. @nickdeveau94 this is mostly your code.