New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gram_schmidt: set default for copy parameter to True? #123

Closed
sdrave opened this Issue Jun 18, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@sdrave
Member

sdrave commented Jun 18, 2015

Since gram_schmidt always returns the orthonormalized matrix and pyMOR usually copies data per default to be on the safe side, the current behaviour is unexpected.

@ftalbrecht, @andreasbuhr, any objections? (Of course, changing the default will break code which assumes that gram_schmidt is in-place by default.)

@sdrave sdrave added this to the 0.4 milestone Jun 18, 2015

@ftalbrecht

This comment has been minimized.

Member

ftalbrecht commented Jun 18, 2015

No objections.

On 18 June 2015 15:00:49 CEST, Stephan Rave notifications@github.com wrote:

Since gram_schmidt always returns the orthonormalized matrix and pyMOR
usually copies data per default to be on the safe side, the current
behaviour is unexpected.

@ftalbrecht, @andreasbuhr, any objections? (Of course, changing the
default will break code which assumes that gram_schmidt is in-place by
default.)


Reply to this email directly or view it on GitHub:
#123

Felix Schindler (born Albrecht)
Applied Mathematics Münster
University of Münster
Orleans-Ring 10, room 120.012
D-48149 Münster, Germany

Tel.: +49 251 83 35130
Fax : +49 251 83 32729
Mail: felix.schindler@wwu.de
WWW: http://felixalbrecht.de

@andreasbuhr

This comment has been minimized.

Contributor

andreasbuhr commented Jun 19, 2015

My code does not use gram_schmidt directly, only gram_schmidt_basis_extension, so no objections.

@sdrave

This comment has been minimized.

Member

sdrave commented Jun 29, 2015

Done in 711393a.

@sdrave sdrave closed this Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment