Skip to content

/ pymor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'with_' from 'BasicInterface' to 'ImmutableInterface'? #154

Closed
sdrave opened this issue Oct 1, 2015 · 2 comments
Closed

Move 'with_' from 'BasicInterface' to 'ImmutableInterface'? #154

sdrave opened this issue Oct 1, 2015 · 2 comments
Milestone
0.4

Comments

@sdrave
Copy link
Member

@sdrave sdrave commented Oct 1, 2015

Right now we have a default implementation that calls __init__ and tries to deduce the arguments from the attributes of the object. For mutable objects this does not seem reasonable, so we should not have such a default implementation and I do not see why each subclass of BasicInterface should be forced to implement with_.
@sdrave sdrave added this to the 0.4 milestone Oct 1, 2015
@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Oct 1, 2015

Sounds reasonable to me.
@sdrave sdrave mentioned this issue Oct 5, 2015
Merged
@sdrave
Copy link
Member Author

@sdrave sdrave commented Oct 6, 2015

Has been implemented in #157.
@sdrave sdrave closed this Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ftalbrecht @sdrave