Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching for discretizations by default #178

Closed
sdrave opened this issue Nov 6, 2015 · 6 comments
Closed

Disable caching for discretizations by default #178

sdrave opened this issue Nov 6, 2015 · 6 comments
Milestone

Comments

@sdrave
Copy link
Member

@sdrave sdrave commented Nov 6, 2015

Currently, the default cache region for discretizations in pymor.discretizations.basic is 'disk'. I propose to change this to None. IMHO, pyMOR should behave as reproducible as possible by default. Having persistent cache entries on disk will change timings in subsequent runs. Moreover, first time users will probably be surprised that pyMOR dumps up to 1GB of data to disk. Re-enabling caching will be as simple as writing

discretization.cache_region = 'disk'

Any objections?

@sdrave sdrave added this to the 0.4 milestone Nov 6, 2015
@renefritze
Copy link
Member

@renefritze renefritze commented Nov 6, 2015

Sounds good. I'm a little concerned if anybody new will do/find that though.

@sdrave
Copy link
Member Author

@sdrave sdrave commented Nov 6, 2015

At least, we could add an option to the demos ..

@renefritze
Copy link
Member

@renefritze renefritze commented Nov 6, 2015

I like that.

@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Nov 9, 2015

So, in view of #179, one would write

discretization.enable_caching(region='disc')

to enable caching and

discretization.disable_caching()

or

discretization.enable_caching(region=None)

to disable caching again?

@sdrave
Copy link
Member Author

@sdrave sdrave commented Nov 9, 2015

Yes, but I would write:

discretization.enable_caching('disk')
@sdrave
Copy link
Member Author

@sdrave sdrave commented Nov 9, 2015

Done in 4c67dd7.

@sdrave sdrave closed this Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants